Skip to content

fix[vortex-array]: update an overflow test#7229

Merged
asubiotto merged 1 commit intodevelopfrom
asubiotto/fsltake
Mar 31, 2026
Merged

fix[vortex-array]: update an overflow test#7229
asubiotto merged 1 commit intodevelopfrom
asubiotto/fsltake

Conversation

@asubiotto
Copy link
Copy Markdown
Contributor

The elements were incorrectly refactored by claude when I got it to clean up and parameterize tests.
This commit actually makes the elements interesting.
Additionally, this adds a to_fixed_size_list to the take so it actually gets executed and would fail without #7214.

Summary

Closes: #000

Testing

The elements were incorrectly refactored by claude when I got it to clean up
and parameterize tests.
Additionally, this adds a to_fixed_size_list to the take so it actually gets
executed and would fail without #7214.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto asubiotto added the changelog/chore A trivial change label Mar 31, 2026
@asubiotto asubiotto enabled auto-merge (squash) March 31, 2026 19:45
@asubiotto asubiotto merged commit 4e4ea56 into develop Mar 31, 2026
63 of 64 checks passed
@asubiotto asubiotto deleted the asubiotto/fsltake branch March 31, 2026 19:50
lwwmanning pushed a commit that referenced this pull request Apr 1, 2026
The elements were incorrectly refactored by claude when I got it to
clean up and parameterize tests.
This commit actually makes the elements interesting.
Additionally, this adds a to_fixed_size_list to the take so it actually
gets executed and would fail without #7214.

<!--
Thank you for submitting a pull request! We appreciate your time and
effort.

Please make sure to provide enough information so that we can review
your pull
request. The Summary and Testing sections below contain guidance on what
to
include.
-->

## Summary

<!--
If this PR is related to a tracked effort, please link to the relevant
issue
here (e.g., `Closes: #123`). Otherwise, feel free to ignore / delete
this.

In this section, please:

1. Explain the rationale for this change.
2. Summarize the changes included in this PR.

A general rule of thumb is that larger PRs should have larger summaries.
If
there are a lot of changes, please help us review the code by explaining
what
was changed and why.

If there is an issue or discussion attached, there is no need to
duplicate all
the details, but clarity is always preferred over brevity.
-->

Closes: #000

<!--
## API Changes

Uncomment this section if there are any user-facing changes.

Consider whether the change affects users in one of the following ways:

1. Breaks public APIs in some way.
2. Changes the underlying behavior of one of the engine integrations.
3. Should some documentation be updated to reflect this change?

If a public API is changed in a breaking manner, make sure to add the
appropriate label. You can run `./scripts/public-api.sh` locally to see
if there
are any public API changes (and this also runs in our CI).
-->

## Testing

<!--
Please describe how this change was tested. Here are some common
categories for
testing in Vortex:

1. Verifying existing behavior is maintained.
2. Verifying new behavior and functionality works correctly.
3. Serialization compatibility (backwards and forwards) should be
maintained or
   explicitly broken.
-->

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Signed-off-by: Will Manning <will@willmanning.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants